[RLlib] Add a test for loading checkpoint v1.0 Policies using the new Policy.from_checkpoint().
#29370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
gjoliver
assigned ArturNiederfahrenhorst, avnishn and sven1977 and unassigned ArturNiederfahrenhorst and avnishn
sven1977
reviewed
Oct 19, 2022
| ) | ||
|
|
||
| policies = Policy.from_checkpoint(path_to_checkpoint) | ||
| self.assertTrue("default_policy", policies) |
There was a problem hiding this comment.
"default_policy" in policies
Also, nit nit: Can we use DEFAULT_POLICY_ID instead?
sven1977
reviewed
Oct 19, 2022
|
|
||
| print(algo.train()) | ||
| algo.stop() | ||
|
|
||
| def test_v1_policy_from_checkpoint(self): |
There was a problem hiding this comment.
Just for my understanding: Any reason, why we shouldn't just do this test case in a loop?
B/c you just want to test Policy (not algo)? Python/pickle versions?
There was a problem hiding this comment.
you mean merge this test with the one above?
the thing is that I need to test DQN policies here. because that is the one we didn't finish migrating to PolicyV2.
it feels a special case compared to the other backward compatibility tests.
we can also remove this test once I move DQN, etc to PolicyV2.
sven1977
reviewed
Oct 19, 2022
sven1977
changed the title
Policy.from_checkpoint().
gjoliver
force-pushed
the
unit_test_for_policy_load
branch
from
2495814
to
9a0e977
Compare
added 3 commits
October 20, 2022 09:45
…nt() API. Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
gjoliver
force-pushed
the
unit_test_for_policy_load
branch
from
9a0e977
to
038f200
Compare
Signed-off-by: Jun Gong <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
… `Policy.from_checkpoint()`. (ray-project#29370) Signed-off-by: Jun Gong <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Gong [email protected]
Why are these changes needed?
Add a unit test to make sure problem fixed by 75e9722 doesn't happen again.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.